[bugfix] fix base-uri() returning empty string instead of the document path #204
Open
Laurettta wants to merge 2 commits into
Open
[bugfix] fix base-uri() returning empty string instead of the document path #204Laurettta wants to merge 2 commits into
Laurettta wants to merge 2 commits into
Conversation
…t path Closes #186 The xml:base lookup in getBaseURI() was returning empty string when the attribute didn't exist. Removed it so we fall through to getDocumentURI() which gives the correct result.
marmoure
requested changes
May 1, 2026
Laurettta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base-uri()was returning an empty string for in-memory documents loaded from disk. The root cause was thatgetBaseURI()inDocumentImplwas checking for anxml:baseattribute on the root element first, but when that attribute wasn't there, it returned empty string instead of falling through. Removed that block sogetDocumentURI()is checked first, which gives the right result.Tests:
Added three JUnit tests in
DocumentImplTest:-
getBaseURI_withDocumentURI: confirms the document URI is returned when set-
getBaseURI_ignoresXmlBaseOnRoot: confirms xml:base on the root element no longer overrides the document URI-
getBaseURI_noDocumentURI: confirms empty string is returned when no document URI is set (existing fallback behaviour preserved)Closes #186