Skip to content

fix(whatsmeow): reuse pooled authDB connection in StartClient instead of leaking a new pool per call #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fmedeiros95 wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −2
Open

fix(whatsmeow): reuse pooled authDB connection in StartClient instead of leaking a new pool per call #174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ade0d2
fix(whatsmeow): reusa o pool de conexoes existente no StartClient
fmedeiros95 Aug 14, 2026
33b6d18
address Sourcery review: guard nil authDB, shorten comment to English
fmedeiros95 Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions pkg/whatsmeow/service/whatsmeow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,17 +316,25 @@ func (w whatsmeowService) StartClient(cd *ClientData) {

var container *sqlstore.Container

if w.config.PostgresAuthDB != "" && w.authDB == nil {
w.loggerWrapper.GetLogger(cd.Instance.Id).LogError("[%s] PostgresAuthDB is set but authDB was never initialized", cd.Instance.Id)
return
}

if w.config.WaDebug != "" {
dbLog := waLog.Stdout("Database", w.config.WaDebug, true)
if w.config.PostgresAuthDB != "" {
container, err = sqlstore.New(context.Background(), "postgres", w.config.PostgresAuthDB, dbLog)
// Reuse the shared, pooled authDB instead of opening a new unbounded pool per call.
container = sqlstore.NewWithDB(w.authDB, "postgres", dbLog)
err = container.Upgrade(context.Background())
} else {
dsn := fmt.Sprintf("file:%s/dbdata/main.db?_pragma=foreign_keys(1)&_busy_timeout=5000&cache=shared&mode=rwc&_journal_mode=WAL", w.exPath)
container, err = sqlstore.New(context.Background(), "sqlite", dsn, dbLog)
}
} else {
if w.config.PostgresAuthDB != "" {
container, err = sqlstore.New(context.Background(), "postgres", w.config.PostgresAuthDB, nil)
container = sqlstore.NewWithDB(w.authDB, "postgres", nil)
err = container.Upgrade(context.Background())
} else {
dsn := fmt.Sprintf("file:%s/dbdata/main.db?_pragma=foreign_keys(1)&_busy_timeout=5000&cache=shared&mode=rwc&_journal_mode=WAL", w.exPath)
container, err = sqlstore.New(context.Background(), "sqlite", dsn, nil)
Expand Down