Make filter.custom generic over the model - #20
Merged
Conversation
Statics cannot reference class type parameters, so the stored FilterHandler stays wide and every handler naming a relation needed a cast at the declaration site. custom<Model> moves that cast inside the package: the declaration site gets the concrete query builder, relation names included, and the runtime is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Statics cannot reference class type parameters, so
FilterHandlerstays wide and handlers naming relations needed a cast per declaration site.custom<Model>moves that single cast inside the package; declaration sites get the concrete builder with typed relation names. Runtime untouched, non-breaking, the type parameter defaults toLucidModel.The test is a compile-time proof: a typed handler assigns a relation name where the wide builder types it as
never. 177 unit + 62 functional passing, lint and typecheck clean.