fix(fetchers): enforce policy for GitHub API subrequests#131
Merged
Conversation
58eeeb0 to
851eb0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
api.github.comsubrequests after the registry only validated the originalgithub.comURL, allowing an egress policy bypass.GETfor its API calls, ignoring callers that requestedHEAD, which could violate caller expectations and policies.Description
GitHubRepoFetcher::validate_policy_urlto enforceallow_prefixes/block_prefixesfor secondary outbound URLs. This helper is invoked before the/repos/{owner}/{repo}and/readmeAPI calls.request.effective_method()to issueGETorHEADfor the repo metadata request, and return early forHEAD(skip README fetch and JSON parsing).HttpMethodto imports and light unit tests for the new policy validation helper (test_validate_policy_url).Testing
cargo test -p fetchkit github_repo -- --nocapture, and all tests passed (10 passed, 0 failed).Codex Task