Fix onChangeText and value TextInput control#43
Open
Alex-Mann wants to merge 2 commits intoevblurbs:masterfrom
Open
Fix onChangeText and value TextInput control#43Alex-Mann wants to merge 2 commits intoevblurbs:masterfrom
Alex-Mann wants to merge 2 commits intoevblurbs:masterfrom
Conversation
Let the user control the value and state of the TextInput as opposed to controlling it internally with component state.
Pass value and onChangeText down to TextInput
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These controls should be left to the user using the component and not set with internal state. Using your own internal state does not allow the user to validate any input going into the component, ie cannot control maximum character length, types of characters allowed, etc.