Skip to content

Privacy assessments dashboard#7391

Open
lucanovera wants to merge 66 commits intomainfrom
ENG-2370-ui-assessment-dashboard-with-progress-tracking
Open

Privacy assessments dashboard#7391
lucanovera wants to merge 66 commits intomainfrom
ENG-2370-ui-assessment-dashboard-with-progress-tracking

Conversation

@lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Feb 13, 2026

Ticket ENG-2370

Description Of Changes

Implement first version of the privacy assessment dashboard. It lists current assessments and allows you to manually trigger new assessments. The feature is in development and hidden behind an alpha feature flag.

Code Changes

  • Added relevant types from models/api to replace hardcoded types
  • Adds reusable TagList component with maxTags and click to expand
  • Adds index page for privacy assessment
  • Adds evaluate page for privacy assessment screen

Steps to Confirm

  1. Visit preview link
  2. Enable alpha feature "Alpha data protection assessments"
  3. Check "Privacy Assessment" options is visible in the menu now and click on it
  4. Check results are displayed in cards and grouped depending on template
  5. Click "Evaluate assessments" button
  6. Check that you can choose an "Assessment templates" and system and Run the evaluation.

Note: the evaluation (specially for all systems) takes too long to wait for it in this screen. There is a followup PR that adds a persistent notification to avoid getting stuck on this screen. The final version will have scheduled runs of the task in the background that will avoid the manual triggering at all.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Feb 19, 2026 3:59pm
fides-privacy-center Ignored Ignored Feb 19, 2026 3:59pm

Request Review

lucanovera and others added 3 commits February 13, 2026 17:47
Co-authored-by: Cursor <cursoragent@cursor.com>
@lucanovera
Copy link
Contributor Author

lucanovera commented Feb 18, 2026

@lucanovera I stopped reviewing because there are just too many HTML and CSS problems, likely AI generated. Please clean those up to conform to our best practices in all of the files.

@gilluminate Yes, most of my work here has been cleaning up the vibe coded UI that was built before I joined the assessments project 😮‍💨 . I apologize for missing all the problems in the AssessmentsCard component and sending it off for review.

I've now refactored a lot of the styling, created css modules, replaced unnecessary specific styles, created reusable components for the tag list and for the icon badges. It's ready for a re-review when you have a chance.

Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements and much easier to review now, thank you for making those updates. I've included several remaining comments and questions now.

@lucanovera
Copy link
Contributor Author

Great improvements and much easier to review now, thank you for making those updates. I've included several remaining comments and questions now.

@gilluminate Thank you for the thorough review! I've apply all of your suggestions and improvements.

I will use this PR review and my refactor commits as input to update our frontend rules. I think currently having someone who isn't a FE dev vibecoding large amounts of UI and then doing cleanup is not efficient. We'll see how it works with more specific rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments