Conversation
…assessments-types-slice
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…sment-dashboard-with-progress-tracking
…thyca/fides into ENG-2370-ui-assessment-dashboard-with-progress-tracking
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
…sment-dashboard-with-progress-tracking
Co-authored-by: Cursor <cursoragent@cursor.com>
@gilluminate Yes, most of my work here has been cleaning up the vibe coded UI that was built before I joined the assessments project 😮💨 . I apologize for missing all the problems in the AssessmentsCard component and sending it off for review. I've now refactored a lot of the styling, created css modules, replaced unnecessary specific styles, created reusable components for the tag list and for the icon badges. It's ready for a re-review when you have a chance. |
gilluminate
left a comment
There was a problem hiding this comment.
Great improvements and much easier to review now, thank you for making those updates. I've included several remaining comments and questions now.
clients/admin-ui/src/features/privacy-assessments/EmptyState.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/privacy-assessments/EmptyState.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/privacy-assessments/AssessmentCard.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/privacy-assessments/AssessmentCard.tsx
Outdated
Show resolved
Hide resolved
…sment-dashboard-with-progress-tracking
@gilluminate Thank you for the thorough review! I've apply all of your suggestions and improvements. I will use this PR review and my refactor commits as input to update our frontend rules. I think currently having someone who isn't a FE dev vibecoding large amounts of UI and then doing cleanup is not efficient. We'll see how it works with more specific rules. |
Ticket ENG-2370
Description Of Changes
Implement first version of the privacy assessment dashboard. It lists current assessments and allows you to manually trigger new assessments. The feature is in development and hidden behind an alpha feature flag.
Code Changes
Steps to Confirm
Note: the evaluation (specially for all systems) takes too long to wait for it in this screen. There is a followup PR that adds a persistent notification to avoid getting stuck on this screen. The final version will have scheduled runs of the task in the background that will avoid the manual triggering at all.
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works