Skip to content

ENG-2640: Remove duplicate cursor config files and update .gitignore#7384

Merged
JadeCara merged 5 commits intomainfrom
ENG-2640-cursor-repo-start
Feb 19, 2026
Merged

ENG-2640: Remove duplicate cursor config files and update .gitignore#7384
JadeCara merged 5 commits intomainfrom
ENG-2640-cursor-repo-start

Conversation

@JadeCara
Copy link
Contributor

@JadeCara JadeCara commented Feb 12, 2026

Ticket ENG-2640

Description Of Changes

Remove cursor configuration files that are now managed in the shared ethyca/cursor repo and update .gitignore to ignore symlinked cursor directories (rules, skills, plans, scripts). Commands remain tracked as repo-specific files.

Code Changes

  • .cursor/rules/general.mdc - Removed (duplicate of shared cursor repo)
  • .cursor/rules/sensitive-info-protection.mdc - Removed (duplicate of shared cursor repo)
  • .gitignore - Added .cursor/rules/, .cursor/skills/, .cursor/plans/, .cursor/scripts/ ignores

Steps to Confirm

  1. Add the new cursor repo to your workspace.
  2. Verify you can access skills.
  3. Verify rules/skills directories are gitignored: git status should not show them as untracked

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration label
    • Add a high-risk label
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • No UX review needed
  • Followup issues:
    • No followup issues
  • Database migrations:
    • No migrations
  • Documentation:
    • No documentation updates required

Made with Cursor

@vercel
Copy link
Contributor

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Feb 19, 2026 0:23am
fides-privacy-center Ignored Ignored Feb 19, 2026 0:23am

Request Review

Jade Wibbels and others added 2 commits February 12, 2026 14:28
@@ -1,10 +0,0 @@
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to new cursor repo.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 17, 2026

Greptile Summary

This PR removes duplicate Cursor configuration files (general rules and sensitive-info-protection rules) that are now managed centrally in the ethyca/cursor shared repository. The .gitignore has been updated to ignore symlinked Cursor directories (rules, skills, plans, scripts) while keeping repo-specific commands tracked.

Key changes:

  • Removed .cursor/rules/general.mdc and .cursor/rules/sensitive-info-protection.mdc
  • Added .cursor/rules/, .cursor/skills/, .cursor/plans/, .cursor/scripts/ to .gitignore
  • Commands directory (.cursor/commands/) remains tracked as repo-specific
  • Changelog entry added appropriately

Important note: Verify that Greptile custom instructions referencing these deleted rule files are updated to point to the new shared repo location.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - it's a simple cleanup removing duplicate configuration files
  • The changes are straightforward configuration management: removing duplicate files now centralized in a shared repo and updating .gitignore accordingly. The .gitignore patterns are correctly formatted and tested. No code logic is affected, and the changelog is properly documented.
  • No files require special attention - all changes are configuration cleanup

Important Files Changed

Filename Overview
.gitignore Added ignores for symlinked Cursor directories (rules, skills, plans, scripts)
changelog/7384-remove-duplicate-cursor-config.yaml Added changelog entry documenting removal of duplicate Cursor config files

Last reviewed commit: 9759758

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 17, 2026

Additional Comments (1)

.cursor/rules/general.mdc
Verify that Greptile custom instructions are updated to reference the new shared cursor repo location instead of these deleted files.

Context Used: Context from dashboard - general instructions (source)

.gitignore Outdated
Comment on lines 263 to 266
.cursor/rules/
.cursor/skills/
.cursor/plans/
.cursor/scripts/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at this point, why not just ./cursor?

Suggested change
.cursor/rules/
.cursor/skills/
.cursor/plans/
.cursor/scripts/
.cursor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated but still tracking the .cursor/rules/sensitive-info-protection.mdc rule

@JadeCara JadeCara requested a review from gilluminate February 19, 2026 00:15
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@JadeCara JadeCara enabled auto-merge February 19, 2026 00:26
@JadeCara JadeCara added this pull request to the merge queue Feb 19, 2026
Merged via the queue into main with commit e005d4e Feb 19, 2026
39 checks passed
@JadeCara JadeCara deleted the ENG-2640-cursor-repo-start branch February 19, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments