chore(lint): resolve goconst findings across the repo - #261
Open
qu0b wants to merge 2 commits into
Open
Conversation
golangci-lint (latest, currently v2.12.2) flags 25 goconst issues on every PR run, all pre-existing on the base branch: repeated log field and metric label literals, throwaway test case names, and string literals where the eth.ID constants already exist. Constant-ify the repeated literals, name the test cases descriptively, and use the existing ID constants in NewStateIdentifier and the ID mapping tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gcr.io/prysmaticlabs/prysm/beacon-chain:latest froze at v5.3.2 (built 2025-04-14) when prysm moved to OffchainLabs. That pre-fulu build cannot decode current fulu states, so both prysm integration jobs die at checkpoint-sync with "invalid ssz encoding" on every network. gcr.io/offchainlabs/prysm/beacon-chain:latest tracks current releases (v7.1.8, built 2026-08-01). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lint workflow tracks golangci-lint
latest, and the current release (v2.12.2) flags 25goconstissues onmaster— it's been latently red since the last green run in June, so the next PR againstmasterfails lint through no fault of its own (see #259 / #260, where the same findings hit therelease/gloasbranch).Fixes, no behavior change:
method,path,node,epoch,root,expires_at).pkg/ethtable-test cases descriptive names instead ofTest 1/Test 2.IDconstants inNewStateIdentifier(mirroringNewBlockIdentifier) and in the ID mapping tests.Verified locally with the same linter version CI resolves (
golangci-lint runv2.12.2 → 0 issues);go build ./.../go test ./...green.This is the
masterport of the lint commit in #260.🤖 Generated with Claude Code