Skip to content

Fix check_consensus_attestation_stats: post-Electra & support for minimal network #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syjn99 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix check_consensus_attestation_stats: post-Electra & support for minimal network #202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06b7f96
Use `aggregationBitsOffset` for calculating vote count post-Electra
syjn99 Jun 26, 2026
715a92e
Add `committeeBitSet`: length(`MAX_COMMITTEES_PER_SLOT`)-agnostic bit…
syjn99 Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions pkg/tasks/check_consensus_attestation_stats/task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,14 +499,19 @@ func (t *Task) aggregateEpochVotes(ctx context.Context, epoch uint64) []*epochVo
continue
}

// committeeBits is a bitfield.Bitvector64, whose BitAt only works at
// the mainnet 8-byte size; under smaller presets it is shorter, so we
// test the bits length-agnostically (see committeeBitSet).
committeeBitsBytes := []byte(committeeBits)

aggregationBitsOffset := uint64(0)

for committee := uint64(0); committee < specs.MaxCommitteesPerSlot; committee++ {
if !committeeBits.BitAt(committee) {
if !committeeBitSet(committeeBitsBytes, committee) {
continue
}

voteAmt, voteCnt, committeeSize := t.aggregateAttestationVotes(votes, uint64(attData.Slot), committee, attAggregationBits, 0)
voteAmt, voteCnt, committeeSize := t.aggregateAttestationVotes(votes, uint64(attData.Slot), committee, attAggregationBits, aggregationBitsOffset)
voteAmount += voteAmt
voteCount += voteCnt
aggregationBitsOffset += committeeSize
Expand Down Expand Up @@ -559,6 +564,12 @@ func (t *Task) aggregateEpochVotes(ctx context.Context, epoch uint64) []*epochVo
return votes
}

// committeeBitSet reports whether the committee-th bit is set in b.
func committeeBitSet(b []byte, committee uint64) bool {
byteIdx := committee / 8
return byteIdx < uint64(len(b)) && b[byteIdx]&(1<<(committee%8)) != 0
}

func (t *Task) aggregateAttestationVotes(votes *epochVotes, slot, committee uint64, aggregationBits bitfield.Bitfield, aggregationBitsOffset uint64) (voteAmount, voteCount, validatorCount uint64) {
attKey := fmt.Sprintf("%v-%v", slot, committee)
voteValidators := votes.attesterDuties.duties[attKey]
Expand Down