Reject malformed client version numbers - #63
Open
kriss39 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject malformed client version numbers instead of silently parsing invalid numeric components as zero.
Details
parseVersionNumberpreviously ignoredstrconv.Atoierrors, so inputs likev1.bad.3orv1.10.badcould be partially parsed and counted as valid client versions. It also accepted version strings with too many numeric components.This change propagates parse failure through the
Version.Errorflag and adds regression coverage for malformed minor, patch, and extra-component version strings.Test
GOCACHE=/private/tmp/codex-go-cache go test -count=1 ./pkg/vparser