Skip to content

fix: backward-compat for ESM etherpad #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamTV12345 merged 1 commit into from
May 25, 2026
+2 −2
Merged

fix: backward-compat for ESM etherpad #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const {template} = require('ep_plugin_helpers');

const eejs = require('ep_etherpad-lite/node/eejs/');
const eejs = require('ep_etherpad-lite/node/eejs');
Copy link
Copy Markdown

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Bugfix lacks regression test 📘 Rule violation ☼ Reliability

Standing rules for agent edits

This PR changes runtime behavior (ESM compatibility) but does not add or update any regression test
in the same commit. Without a regression test, the trailing-slash resolution issue could be
reintroduced unnoticed.
Agent Prompt 
## Issue description
A bug fix was made (changing the `eejs` require path to remove the trailing slash) but no regression test was added/updated alongside the fix.

## Issue Context
The compliance rule requires every bug fix to include a regression test in the same commit/PR so the issue is verifiable and cannot silently regress.

## Fix Focus Areas
- index.js[5-5]
- static/tests/frontend-new/specs/smoke.spec.ts[1-13]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

const {padToggle} = require('ep_plugin_helpers/pad-toggle-server');

// Parallel User Settings + Pad Wide Settings checkboxes for the reference
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "ep_reference",
"description": "Reference content from other Pads",
"version": "0.1.7",
"version": "0.1.8",
"author": "johnyma22 (John McLear) <john@mclear.co.uk>",
"repository": {
"type": "git",
Expand Down
Loading