Skip to content

Fix embassy_sntp example#5239

Merged
bugadani merged 3 commits intomainfrom
nightly-ci
Mar 23, 2026
Merged

Fix embassy_sntp example#5239
bugadani merged 3 commits intomainfrom
nightly-ci

Conversation

@JurajSadel
Copy link
Copy Markdown
Contributor

@JurajSadel JurajSadel commented Mar 21, 2026

Fixes new versions

closes #5238

@JurajSadel JurajSadel added the skip-changelog No changelog modification needed label Mar 21, 2026
bugadani
bugadani reviewed Mar 21, 2026
View reviewed changes
Comment thread examples/wifi/embassy_sntp/Cargo.toml Outdated
@JurajSadel @bugadani
applied suggestion
6d1385f 
Co-authored-by: Dániel Buga <bugadani@gmail.com>
SergioGasquez
SergioGasquez approved these changes Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bugadani
Copy link
Copy Markdown
Contributor

bugadani commented Mar 23, 2026 •
edited
Loading

Well maybe this one example is enough to fix the nightly CI fail, but embassy_usb_ethernet is broken because of picoserve. The way around that (until picoserve becomes a better citizen and stops breaking on every embassy-net update) is to upgrade to embassy-net 0.9, and generally to update the rest of the embassy crates.

@JurajSadel
Copy link
Copy Markdown
Contributor Author

JurajSadel commented Mar 23, 2026

Well maybe this one example is enough to fix the nightly CI fail, but embassy_usb_ethernet is broken because of picoserve. The way around that (until picoserve becomes a better citizen and stops breaking on every embassy-net update) is to upgrade to embassy-net 0.9, and generally to update the rest of the embassy crates.

I played with it a bit and I couldn't make it to work as picoserve pulls embassy-net 0.9 and edge-nal-embassy pulls embassy-net 0.8, so unless I haven't missed something we might be stuck here?

@bugadani
Copy link
Copy Markdown
Contributor

bugadani commented Mar 23, 2026

Maybe we can commit the Cargo.lock file for the usb_ethernet example that forces it to use embassy-net 0.8, but I can't check out this PR with gh pr checkout 🙃

@JurajSadel
Copy link
Copy Markdown
Contributor Author

JurajSadel commented Mar 23, 2026

Maybe we can commit the Cargo.lock file for the usb_ethernet example that forces it to use embassy-net 0.8, but I can't check out this PR with gh pr checkout 🙃

Yes, seems this works fine 👍

@bugadani bugadani added this pull request to the merge queue Mar 23, 2026
Merged via the queue into main with commit 81bf33e Mar 23, 2026
60 checks passed
@JurajSadel JurajSadel deleted the nightly-ci branch March 23, 2026 11:56
bugadani added a commit to bugadani/esp-hal that referenced this pull request Mar 24, 2026
@JurajSadel @bugadani
Fix embassy_sntp example (esp-rs#5239)
401c679 
* Fix embassy_sntp example

* applied suggestion

Co-authored-by: Dániel Buga <bugadani@gmail.com>

* Force embassy-net to be 0.8 in picoserve

---------

Co-authored-by: Dániel Buga <bugadani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bugadani bugadani bugadani left review comments

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees

No one assigned

Labels

skip-changelog No changelog modification needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nightly CI Failure

3 participants

@JurajSadel @bugadani @SergioGasquez