fix(explorer): serialize and configure refresh polling - #522
Open
itaober wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent CodeDiff's explorer polling from launching overlapping Git work, and allow users to configure the polling interval.
This affects repositories undergoing large external change bursts—for example, coding agents editing many files, code generators, formatters, rebases, or branch switches. When a refresh takes longer than the polling interval, the next tick previously started another asynchronous scan. Repeated overlap could accumulate Git processes and file descriptors, increase CPU and security-scanner activity, apply stale callbacks out of order, and eventually fail with
EMFILE: too many open files.Root cause
The 500ms poll introduced in #483 starts
git statusand mutable revision synchronization on every tick without checking whether the previous cycle has finished.In a large or rapidly changing working tree:
Changes
explorer.auto_refresh:true: poll every 500ms, preserving the current default.false: disable automatic polling.Benefits
Configuration
Validation
stylua --checkon modified Lua and test filesgit diff --checkRelated