Decompose generate_pdf_report into section functions and add unit tests#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decomposes the 630-line generate_pdf_report monolith in core/utils_report.py into individually testable section-building functions, and adds unit tests for each.
This PR extracts seven private build* functions (summary, scope, cost, risk, scoring, resource inventory, alternative technologies) that each return a list of ReportLab flowables, plus a shared _default_table_style() helper that replaces the duplicated table style definitions. The public generate_pdf_report function becomes a ~30-line orchestrator with an unchanged signature, so callers and PDF output are unaffected. A new tests/test_pdf_sections.py adds 25 unit tests covering each extracted function, edge cases (empty data, unknown providers), and the previously untested anonymize_string utility.