Fix incorrect condition for JSON report path, default currency for empty cost data, and remove dead except block#30
Merged
Merged
Conversation
…pty cost data, and remove dead except block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three small correctness bugs found during the codebase audit.
This PR fixes a copy-paste error in main.py where the JSON report path output checked the wrong variable (html_report_path instead of json_report_path), adds a currency = "USD" default before the cost data loop in both AWS and Azure cost builders to prevent an UnboundLocalError when the cloud API returns zero rows, and removes an unreachable duplicate except Exception block at the end of build_aws_cost_inventory.