deps: Bump Microsoft.SqlServer.TransactSql.ScriptDom and SQLitePCLRaw.bundle_e_sqlite3 - #420
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
erikdarlingdata
left a comment
There was a problem hiding this comment.
Dependabot patch/minor group bump touching three .csproj files:
Microsoft.SqlServer.TransactSql.ScriptDom180.59.2 → 180.78.1 insrc/PlanViewer.App/PlanViewer.App.csproj:27andsrc/PlanViewer.Core/PlanViewer.Core.csproj:14SQLitePCLRaw.bundle_e_sqlite33.0.4 → 3.0.5 inserver/PlanShare/PlanShare.csproj:17
Base branch dev — correct. build-and-test is green; check-branches is green; only the review action is red, and it's failing on every recent dependabot PR (also #421), so that looks like a workflow-side issue rather than something this PR broke. No src/ logic changes and no test updates — the coverage rule doesn't apply.
What needs attention
-
Stale comment in
server/PlanShare/PlanShare.csproj:14-16— see inline. The comment says "3.0.4 bundles SQLite 3.53.3"; after the bump the ref is 3.0.5, which bundles SQLite 3.53.4. Since the block exists specifically to document the CVE-2025-6965 rationale and the pinned native SQLite version, it needs to move with the ref. -
ScriptDom is a 19-patch jump (180.59.2 → 180.78.1). Within-major, so API-stable, but the parser rule tables can shift. Consumers in this repo:
src/PlanViewer.Core/Services/SqlObjectResolver.cs,src/PlanViewer.App/Services/SqlFormattingService.cs,src/PlanViewer.App/Services/SqlFormatSettingsService.cs. Worth a smoke pass through object-resolution and format-selection scenarios before merge — nothing in the diff itself is wrong.
Not approving, not requesting changes — comments only.
Generated by Claude Code
| drop it only once that floor moves past 2.1.11 on its own. 3.0.4 bundles | ||
| SQLite 3.53.3, and Microsoft.Data.Sqlite 10.0.10 works against the 3.x | ||
| native layer (full CRUD verified). --> |
There was a problem hiding this comment.
Comment is stale after this bump: "3.0.4 bundles SQLite 3.53.3" but line 17 now pins 3.0.5, which per the 3.0.5 release notes bundles SQLite 3.53.4 (package ID SQLite). Update the comment to 3.0.5 bundles SQLite 3.53.4 so the CVE-2025-6965 rationale stays accurate — the whole point of the block comment is documenting what native SQLite version this ref pins.
Generated by Claude Code
|
@dependabot rebase |
|
@dependabot recreate |
….bundle_e_sqlite3 Bumps Microsoft.SqlServer.TransactSql.ScriptDom from 180.59.2 to 180.78.1 Bumps SQLitePCLRaw.bundle_e_sqlite3 from 3.0.4 to 3.0.5 --- updated-dependencies: - dependency-name: Microsoft.SqlServer.TransactSql.ScriptDom dependency-version: 180.78.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patch-and-minor - dependency-name: Microsoft.SqlServer.TransactSql.ScriptDom dependency-version: 180.78.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patch-and-minor - dependency-name: Microsoft.SqlServer.TransactSql.ScriptDom dependency-version: 180.78.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patch-and-minor - dependency-name: Microsoft.SqlServer.TransactSql.ScriptDom dependency-version: 180.78.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patch-and-minor - dependency-name: SQLitePCLRaw.bundle_e_sqlite3 dependency-version: 3.0.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-and-minor ... Signed-off-by: dependabot[bot] <support@github.com>
720ee0b to
f491a3e
Compare
Updated Microsoft.SqlServer.TransactSql.ScriptDom from 180.59.2 to 180.78.1.
Release notes
Sourced from Microsoft.SqlServer.TransactSql.ScriptDom's releases.
No release notes found for this version range.
Commits viewable in compare view.
Updated SQLitePCLRaw.bundle_e_sqlite3 from 3.0.4 to 3.0.5.
Release notes
Sourced from SQLitePCLRaw.bundle_e_sqlite3's releases.
3.0.5
Update the lib dependency for
SQLitePCLRaw.bundle_e_sqlite3to package IDSQLiteversion 3.53.4.Commits viewable in compare view.