Perf: offload Lite picker charts, overview sweep, connect, timeline lanes (P1c)#1112
Merged
Merged
Conversation
…anes (P1c) - Wait/clerk/perfmon picker chart updates: wrap the per-series GetXTrendAsync in Task.Run, and add a per-picker generation guard (bail after each now-genuinely- async query if a newer invocation started). The guard also fixes the latent double-plot on rapid checkbox toggling — which the offload would otherwise have made real, since everything was synchronous before. - MainWindow.RefreshOverviewAsync: the 30s status sweep now runs each server's GetServerSummaryAsync on a pool thread. - ConnectToServer: RunAllCollectorsForServerAsync now runs off the dispatcher (the scheduled path already did; the tab-open path didn't). - CorrelatedTimelineLanesControl (Overview tab): the 6 lane queries + 4 baseline lookups + 5 comparison-overlay queries now run on pool threads. Build: Lite builds clean (net10). Remaining on this effort: drill-down, slicer-change handlers, grid selection, then a bounded read lock; then shared-UI crosshair, the Dashboard chunk, leak cluster. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the Lite off-thread work (P1c).
GetXTrendAsyncwrapped inTask.Run+ a per-picker generation guard (bail after each now-async query if a newer invocation started). The guard also fixes the latent double-plot on rapid checkbox toggling — which the offload would otherwise have made real.RefreshOverviewAsync): each server'sGetServerSummaryAsyncruns on a pool thread.RunAllCollectorsForServerAsyncnow runs off the dispatcher (scheduled path already did).Build: Lite clean (net10). Threading change — validate on a running Lite.
Remaining: drill-down, slicer-change handlers, grid selection, bounded read lock; then shared-UI crosshair, Dashboard chunk, leak cluster.
🤖 Generated with Claude Code