eels: suggestions for ethereum/hive#1566#3
Open
danceratopz wants to merge 4 commits into
Open
Conversation
Gate tarball extraction on the build arg so a staged fixtures.tar.gz without fixtures=/fixtures no longer bloats the final image with unused extracted fixtures alongside the downloaded release.
… is reused Official EEST release tarballs prefix all content with fixtures/ and ship a pre-generated .meta/index.json. Stripping the top-level dir places the index at <input>/.meta/index.json where consume looks for it, so index regeneration (a full parse of every fixture JSON) is skipped at build time.
Prevents a staged multi-GB fixtures.tar.gz from being accidentally committed from a CI or dev checkout.
spencer-tb
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestions for ethereum#1566: gate extraction on
fixtures=/fixtures, add--strip-components=1so the shipped fixtures index is reused (skips index regeneration on each--docker.nocachebuild), gitignore staged tarballs, tighten comments.