Repository navigation
Conversation
PyObject_Pretty() is part of the limited API from 3.16, but it was declared without a version guard. An extension built against an older limited API, such as Py_LIMITED_API=0x030a0000, could compile against it and then fail to load on Python 3.10 through 3.15. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyObject_Pretty()is registered inMisc/stable_abi.tomlas added in 3.16, and the generated stable ABI files include it, but its declaration inInclude/object.hhad no version guard. An extension built against an older limited API, such asPy_LIMITED_API=0x030a0000, could compile against it and then fail to load on Python 3.10 through 3.15.This wraps the declaration in
#if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 >= 0x03100000, as with other limited API additions.make check-limited-abidoesn't check these guards, which is why it passed before.Checked with the compiler: with
Py_LIMITED_API=0x030a0000the function is undeclared, and with0x03100000or the full API it's visible.make check-limited-abi, test_stable_abi_ctypes, test_capi, test_fstring and test_tstring pass.🤖 Generated with Claude Code