Repository navigation
Fix PEP 813 printer regressions after the C migration - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C migration left the printer referring to document classes removed by the marker-table refactor, so even a basic
f'{[1, 2]!p}'raisesNameError. Restore marker lookup, layout, rendering, and width measurement through the existing marker table, and remove the superseded literal-rendering code.Also restore the Python leaf markers' use of
__name__in their representations, preserve an explicitLayout.closewhenopenis omitted, and applyPrettyPrinter's width, indent, and depth validation and numeric coercion toPrinter. Add regression tests for delimiter handling and constructor options; the existing marker tests cover the rendering and representation regressions.Validation: rebuilt the interpreter with
make -j4; all 674 tests passed acrosstest__pprint,test_pprint,test_fstring,test_tstring,test_dataclasses,test_string.test_templatelib,test_format, andtest_collections.git diff --checkpasses.Prepared with OpenAI Codex assistance.