[pull] master from reactive:master#114
Merged
pull[bot] merged 3 commits intoerickirt:masterfrom Apr 6, 2026
Merged
Conversation
…ft() (#3876) GlobalCache.getResults() called unshift() on every cache-miss denormalization, which is O(n) because it shifts all existing elements. Pre-allocate slot 0 with a placeholder and fill it in-place, turning the operation into O(1). Benchmarks showed 1.3–3.2% improvement on cold-denormalize paths (denormalizeLong variants). Made-with: Cursor
…h switch (#3877) getDependency used delegate[['', ...][path.length]](...path) — a computed property lookup with spread that creates a temporary array on every call and prevents V8 from inlining or type-specializing the dispatch. Replace with an explicit switch on path.length for monomorphic call sites. V8 trace showed getNewEntities deopt changing from "Insufficient type feedback for generic named access" to a different reason after this fix, consistent with removing the megamorphic dispatch from the call path. Made-with: Cursor
…#3878) The normalize() return object was constructed with result: '' as any, then mutated via ret.result = visit(...). This causes a V8 hidden class transition when the property type changes from string to the actual result type (array/object/string), triggering "field type constness changed" invalidations that deoptimize code depending on this object shape. Restructured to compute the result first and construct the final NormalizedSchema in a single step, keeping the object shape stable from creation. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )