-
Notifications
You must be signed in to change notification settings - Fork 35
Update ruff version and add preview rules #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
=======================================
Coverage 83.44% 83.44%
=======================================
Files 49 49
Lines 7287 7287
=======================================
Hits 6081 6081
Misses 1206 1206 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the ruff linter version and enables preview rules, resulting in code improvements focused on performance optimizations and code simplification. The changes primarily involve replacing list/tuple literals with set literals where appropriate, simplifying string operations, and improving variable naming conventions.
Changes:
- Enabled ruff preview mode and added several new linting rule ignores in pyproject.toml
- Replaced list/tuple literals with set literals in membership tests for performance
- Simplified string operations (e.g., using
+=instead of concatenation,rsplitwith maxsplit) - Improved variable naming by avoiding shadowing built-in names (e.g.,
class_instead of_class) - Replaced
os.chdir()calls withmonkeypatch.chdir()in test fixtures for better test isolation
Reviewed changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Enabled ruff preview mode and added new rule ignores |
| tests/*.py (multiple files) | Replaced os.chdir() with monkeypatch.chdir() for test isolation |
| tests/utils.py | Changed list to set literal in membership tests |
| tests/test_*.py (multiple files) | Added monkeypatch parameter to test functions and fixtures |
| src/subscript/**/*.py (multiple files) | Applied performance optimizations, simplified string operations, and improved variable naming |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@larsevj The PR looks good to me. The copilot comments seem to make sense for me but it seems like that was exactly what it was before PR. Do they get flagged by this new ruff rule? |
I just scrapped that rule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 61 out of 61 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alifbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
No description provided.