Skip to content

ci: allow workshops without a typecheck script #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kody-bot merged 5 commits into from
Jul 29, 2026
+7 −7
Merged

ci: allow workshops without a typecheck script #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f868d0
ci: allow workshops without typecheck script
cursoragent Jul 29, 2026
25ead7d
ci: install Playwright with supported Node version
cursoragent Jul 29, 2026
3c2740b
ci: run Playwright tests on Node 22
cursoragent Jul 29, 2026
52d3dca
test: wait for routable ship link
cursoragent Jul 29, 2026
e4a4306
test: select pathname-based ship route
cursoragent Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
done

- name: ʦ TypeScript
run: npm run typecheck
run: npm run typecheck --if-present
working-directory: ./workshop

- name: ⬣ Lint
Expand All @@ -83,7 +83,9 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@v4
with:
node-version: 26
# Playwright 1.51's browser install and test runner hang under Node 26.
# The setup matrix above still validates the workshop under Node 26.
node-version: 22

- name: 📦 Install dependencies
run: npm ci
Expand Down
8 changes: 3 additions & 5 deletions exercises/04.router/01.solution.router/tests/client-side-routing.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,9 @@ test('should display the home page and perform client-side routing', async ({
reloadCount++
})

// Wait for the page to load
await page.waitForSelector('a')

// Get the first link
const firstLink = await page.locator('a').first()
// Wait for the streamed search results to replace placeholder "#" links.
const firstLink = page.locator('a[href^="/"]').first()
await firstLink.waitFor()

// Get the href attribute of the first link
const href = await firstLink.getAttribute('href')
Expand Down
Loading