fcds: fix review findings - #46762
Open
kyessenov wants to merge 1 commit into
Open
Conversation
Change-Id: Ic991843cb4fec43a347b1ec40ba420e4e23b7983 Signed-off-by: Kuat Yessenov <kuat@google.com>
| return absl::InvalidArgumentError( | ||
| "Invalid FCDS update: cannot add and remove in the same update"); | ||
| } | ||
| if (added == 0 && removed == 0) { |
Contributor
There was a problem hiding this comment.
These series if ... els conditions are a little bit hard to understand. A few questions, could added > 1 > Could removed > 1? What are the valid cases?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Ic991843cb4fec43a347b1ec40ba420e4e23b7983
Commit Message: address some minor improvements found during a secondary review
Additional Description:
Risk Level: low
Testing: done
Docs Changes: none
Release Notes: none