install/script: fix warnings reported by ShellCheck 0.11 - #706
Merged
Merged
Conversation
ShellCheck 0.11 flags reading $? after a bare test command in configure and the += status accumulation in script/mt, which appends a string instead of adding a number. Turn the former into an explicit if/else and the latter into a plain assignment. Assisted-by: Claude:claude-fable-5-1 Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShellCheck 0.11 makes
make testlintfail on two spots: reading$?after a baretestcommand inconfigure(SC2319) and the+=status accumulation inscript/mt(SC2324), which appends a string instead of adding a number. The former is turned into an explicit if/else, the latter into a plain assignment.