Repository navigation
feat: Download prebuilt plugin binaries instead of building with Go - #19
Merged
Merged
Conversation
|
🚀 env0 had composed a PR Plan for environment ACME Financial Services / Demos / Plugins Demo / env0-import-variable-plugin test : |
erezrokah
force-pushed
the
claude/modest-maxwell-462744
branch
from
October 20, 2026 09:39
dc69dc8 to
7b0740b
Compare
erezrokah
marked this pull request as ready for review
October 20, 2026 14:49
dcelasun
approved these changes
Oct 21, 2026
dcelasun
left a comment
There was a problem hiding this comment.
@erezrokah LGTM. Notes:
env0.plugin.yaml:use: ...@0.5.0still downloadsreleases/latestunlessinputs.versionis also set, so a pinned ref doesn't pin the binary. Derive it from the ref, or document both together.- The README example drops the
@<tag>pin. test/env0.yamlnow runs main's plugin, so PR plans no longer exercise the PR's own script.- Nit: curl has no
--connect-timeout/--max-time, so a firewalled self-hosted agent can stall before it falls back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the plugin to download the release binary for the agent architecture (the release that matches the plugin version, set in
PLUGIN_DEFAULT_VERSIONand checked against the tag by the release workflow, or the new optionalversioninput), verify its SHA-256 checksum, and fall back to the old build from source (cloning the default branch if the version tag does not exist) when any step fails, so it no longer installs Go on every run, and make the test flow use the published plugin; users who copied the old script into theirenv0.yamlmust switch touse: https://github.com/env0/env0-import-variable-pluginto benefit.