Skip to content

Make E2E pass and add some more tests#343

Merged
gtrrz-victor merged 18 commits intomainfrom
soph/1to1-bugs-found-by-e2e
Feb 16, 2026
Merged

Make E2E pass and add some more tests#343
gtrrz-victor merged 18 commits intomainfrom
soph/1to1-bugs-found-by-e2e

Conversation

@Soph
Copy link
Collaborator

@Soph Soph commented Feb 15, 2026

Follow up to #336 and #325

  • E2E suite passes now
  • Added more tests
  • Updated how we consider a change to belong to the last session after partial commits
  • E2E suite also working for Gemini

Soph added 10 commits February 15, 2026 11:20
…, files_touched count fixed

Entire-Checkpoint: 629d7ea05f37
Entire-Checkpoint: dceb05739de3
Entire-Checkpoint: 1871e706e10d
Entire-Checkpoint: ce258fedd6ee
Entire-Checkpoint: 044ed289c318
Entire-Checkpoint: d38f8f80fa82
Entire-Checkpoint: 57f1f346970c
Entire-Checkpoint: dd4dd63ec25c
@Soph Soph requested a review from a team as a code owner February 15, 2026 16:38
Copilot AI review requested due to automatic review settings February 15, 2026 16:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a follow-up to PRs #336 (E2E tests) and #325 (1:1 checkpoint model). It fixes issues that prevented the E2E test suite from passing and adds comprehensive test coverage for various checkpoint scenarios.

Changes:

  • Enhanced content-aware overlap detection with significant line comparison to handle partial staging scenarios
  • Updated CondenseSession signature to accept committedFiles parameter for accurate 1:1 checkpoint-to-commit filtering
  • Improved E2E test infrastructure with better git stash handling and helper functions
  • Added comprehensive E2E tests for subagent checkpoints, existing file modifications, and complex workflow scenarios

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
manual_commit_test.go Updated all test calls to CondenseSession with new signature (added nil parameter)
manual_commit_hooks.go Enhanced sessionHasNewContent logic to handle carry-forward and partial staging scenarios; pass committedFiles to condensation
manual_commit_condensation.go Added committedFiles parameter to CondenseSession and filtering logic to ensure 1:1 checkpoint-to-commit mapping
content_overlap.go Added sophisticated content overlap detection with hasSignificantContentOverlap, extractSignificantLines, and isTrivialLine functions to distinguish partial staging from revert-and-replace
auto_commit.go Pass transcript path to checkpoint store for content hash generation
e2e_test/testenv.go Added GitAddAll, GetLatestCheckpointID helpers; changed GitStash to use -u flag; commit config files after entire enable
e2e_test/scenario_subagent_test.go New comprehensive tests for subagent/task checkpoint creation and commit flows
e2e_test/scenario_rewind_test.go Updated rewind tests to verify that shadow branch IDs become invalid after commit (logs-only points have different IDs)
e2e_test/scenario_checkpoint_workflows_test.go Removed transcript content validation (too flaky); added extensive tests for existing file modification scenarios
e2e_test/scenario_checkpoint_test.go Enhanced auto-commit test with better assertions and checkpoint validation
e2e_test/prompts.go Added PromptUseTaskTool template for testing subagent functionality
CLAUDE.md Added comprehensive E2E test documentation with warnings about API costs and environment variables

Soph added 4 commits February 15, 2026 18:02
Entire-Checkpoint: f7a71cacaeea
Entire-Checkpoint: 85264e2287b3
@Soph
Copy link
Collaborator Author

Soph commented Feb 15, 2026

cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

@gtrrz-victor gtrrz-victor merged commit 237b343 into main Feb 16, 2026
3 checks passed
@gtrrz-victor gtrrz-victor deleted the soph/1to1-bugs-found-by-e2e branch February 16, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants