Make E2E pass and add some more tests#343
Merged
gtrrz-victor merged 18 commits intomainfrom Feb 16, 2026
Merged
Conversation
…, files_touched count fixed Entire-Checkpoint: 629d7ea05f37
Entire-Checkpoint: dceb05739de3
Entire-Checkpoint: 1871e706e10d
…lti commit Entire-Checkpoint: 897eb280e769
Entire-Checkpoint: f7cda7fbdf38
Entire-Checkpoint: ce258fedd6ee
Entire-Checkpoint: 044ed289c318
Entire-Checkpoint: d38f8f80fa82
Entire-Checkpoint: 57f1f346970c
Entire-Checkpoint: dd4dd63ec25c
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a follow-up to PRs #336 (E2E tests) and #325 (1:1 checkpoint model). It fixes issues that prevented the E2E test suite from passing and adds comprehensive test coverage for various checkpoint scenarios.
Changes:
- Enhanced content-aware overlap detection with significant line comparison to handle partial staging scenarios
- Updated
CondenseSessionsignature to acceptcommittedFilesparameter for accurate 1:1 checkpoint-to-commit filtering - Improved E2E test infrastructure with better git stash handling and helper functions
- Added comprehensive E2E tests for subagent checkpoints, existing file modifications, and complex workflow scenarios
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
manual_commit_test.go |
Updated all test calls to CondenseSession with new signature (added nil parameter) |
manual_commit_hooks.go |
Enhanced sessionHasNewContent logic to handle carry-forward and partial staging scenarios; pass committedFiles to condensation |
manual_commit_condensation.go |
Added committedFiles parameter to CondenseSession and filtering logic to ensure 1:1 checkpoint-to-commit mapping |
content_overlap.go |
Added sophisticated content overlap detection with hasSignificantContentOverlap, extractSignificantLines, and isTrivialLine functions to distinguish partial staging from revert-and-replace |
auto_commit.go |
Pass transcript path to checkpoint store for content hash generation |
e2e_test/testenv.go |
Added GitAddAll, GetLatestCheckpointID helpers; changed GitStash to use -u flag; commit config files after entire enable |
e2e_test/scenario_subagent_test.go |
New comprehensive tests for subagent/task checkpoint creation and commit flows |
e2e_test/scenario_rewind_test.go |
Updated rewind tests to verify that shadow branch IDs become invalid after commit (logs-only points have different IDs) |
e2e_test/scenario_checkpoint_workflows_test.go |
Removed transcript content validation (too flaky); added extensive tests for existing file modification scenarios |
e2e_test/scenario_checkpoint_test.go |
Enhanced auto-commit test with better assertions and checkpoint validation |
e2e_test/prompts.go |
Added PromptUseTaskTool template for testing subagent functionality |
CLAUDE.md |
Added comprehensive E2E test documentation with warnings about API costs and environment variables |
Entire-Checkpoint: b036f59168c8
Entire-Checkpoint: f7a71cacaeea
Entire-Checkpoint: 92a0e41fd911
Entire-Checkpoint: 85264e2287b3
Collaborator
Author
|
cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Entire-Checkpoint: b0dc55b3a1dc
Entire-Checkpoint: f43b0ea5ee16
gtrrz-victor
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #336 and #325