fix: show optional sender attributes in email and download flow#35
Open
rubenhensen wants to merge 6 commits intomainfrom
Open
fix: show optional sender attributes in email and download flow#35rubenhensen wants to merge 6 commits intomainfrom
rubenhensen wants to merge 6 commits intomainfrom
Conversation
- Pass senderAttributes to the backend (FileProvider.ts) so the server can include them in the notification email sent to recipients - Show optional sender attributes (e.g. mobile number, full name) in the download/decryption flow's "Ready" state alongside the verified sender email, consistent with how they are already shown in the "Done" state
…run simultaneously
Contributor
Author
|
Still only shows email |
- Remove UI for manually selecting optional attributes (SenderInputs); the PKG now always requests them as optional in every signing session - Fix yivi-tools: always pass all optional attr types as privSignId so PKG can build the private signing key from what the user disclosed - Pass the actual disclosed attrs (privSignKey.policy.con) to the file store so the download email shows the verified optional attributes
- Always encrypt for the sender (no more optional checkbox) - Remove remaining senderAttributes spread that was causing TypeError - Remove SenderInputs component and senderConfirm from EncryptState entirely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
senderAttributesto the backend (FileProvider.ts) so the server can include optional sender attributes (e.g. mobile number, full name) in the notification email sent to recipientsCloses #28