fix: dropzone focus state and add-more-files button semantics#32
Merged
rubenhensen merged 4 commits intomainfrom Apr 3, 2026
Merged
fix: dropzone focus state and add-more-files button semantics#32rubenhensen merged 4 commits intomainfrom
rubenhensen merged 4 commits intomainfrom
Conversation
…s a button (#23) - Add :focus-visible outline to the remove button in UploadedFileTemplate for keyboard visibility - Pass onclick to the Chip component in FileInput so it renders as a <button> element, fixing keyboard accessibility and semantics for the "add more files" control
…run simultaneously
- Add focus-visible outline + z-index to remove button in dropzone - Override Dropzone's default white background on file previews - Use overflow:clip with clip-margin on dz-previews and help-section so focus outlines aren't cut off by scroll containers - Add z-index to HelpToggle focus state so outline paints above sibling recipient cards - Restore primary-btn focus-visible outline on 1dppx screens (was incorrectly set to outline:none)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:focus-visible) to the remove (✕) button in the dropzone component, matching the same outline style used elsewhere in the codebase<button>element by passing anonclickprop to theChipcomponent inFileInput.svelte, ensuring correct keyboard accessibility and semanticsoverflow: clipwithoverflow-clip-marginon.dz-previewsand.help-section)z-indexto HelpToggle focus state so the outline paints above sibling recipient cardsprimary-btnfocus-visible outline on 1dppx screens (was incorrectly set tooutline: none)background: transparentCloses #23