Fix base_url query parameters corrupted during URL merging#3766
Open
Fridayai700 wants to merge 1 commit intoencode:masterfrom
Open
Fix base_url query parameters corrupted during URL merging#3766Fridayai700 wants to merge 1 commit intoencode:masterfrom
Fridayai700 wants to merge 1 commit intoencode:masterfrom
Conversation
When base_url contains query parameters (e.g. "https://example.com/get?data=1"), _enforce_trailing_slash() appended "/" to raw_path which includes the query string, corrupting "?data=1" into "?data=1/". Similarly, _merge_url() concatenated paths without separating the query string from the path component. Fix both methods to split raw_path at "?" before manipulating the path, then rejoin with the query string intact. Fixes encode#3614 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_enforce_trailing_slash()appending/after query string inraw_path, corrupting?data=1into?data=1/_merge_url()concatenating paths without separating query string from path componentraw_pathat?before path manipulation, then rejoin with query intactFixes #3614
Test plan
test_merge_url_with_base_url_query_paramscovering empty merge path and subpath merge