Release HTTP/2 semaphore permit on NoAvailableStreamIDError#1061
Open
bysiber wants to merge 1 commit intoencode:masterfrom
Open
Release HTTP/2 semaphore permit on NoAvailableStreamIDError#1061bysiber wants to merge 1 commit intoencode:masterfrom
bysiber wants to merge 1 commit intoencode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the HTTP/2 implementation,
handle_async_request/handle_requestacquires a_max_streams_semaphorepermit before getting a stream ID. Ifget_next_available_stream_id()raisesNoAvailableStreamIDError, the exception handler correctly sets_used_all_stream_idsand decrements the request count, but it doesn't release the semaphore permit that was just acquired:This permanently leaks one semaphore permit. While the practical impact is limited since
_used_all_stream_ids = Trueprevents further requests on this connection, it's still incorrect resource cleanup.This adds the missing
release()call in both the async and sync implementations.