Conversation
This reverts commit 54cd688.
kripken
approved these changes
Apr 10, 2026
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Do you or @mymindstorm know why we didn't see errors earlier, if the previous PR was wrong?
Collaborator
Author
|
It not something one would necessarily see error with.. its more like the type definitions we are using should match the node version we are targeting right? With a mismatch there is risk you that typescript and node disagree on some things. |
mymindstorm
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #64