Repository navigation
Add missing direct __deps entries across JS libraries. NFC - #28060
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several Emscripten library files (including libaddfunction.js, libcore.js, libdylink.js, libfs_shared.js, libopenal.js, libpthread.js, libwasm_worker.js, and libwebaudio.js) to explicitly declare missing dependencies (__deps) for various internal functions and variables. This ensures correct dependency tracking and code generation during the build process. Additionally, test files and expected code sizes have been updated to reflect these changes. No review comments were provided, so there is no additional feedback to address.
sbc100
force-pushed
the
missing-js-deps
branch
from
October 23, 2026 21:25
905bd6e to
beef068
Compare
kripken
reviewed
Oct 23, 2026
sbc100
force-pushed
the
missing-js-deps
branch
from
October 23, 2026 23:25
beef068 to
2f90f73
Compare
Add missing direct `__deps` declarations for JS library symbols that previously relied on other callers pulling in their dependencies later in the dependency graph. With `__ps` sorted alphabetically (emscripten-core#28059), adding these missing direct edges ensures that automatically computing JS-to-JS dependencies (emscripten-core#27995) produces identical declaration ordering and zero diffs across `test/codesize/`. See: emscripten-core#19098
sbc100
force-pushed
the
missing-js-deps
branch
from
October 23, 2026 23:40
2f90f73 to
aaa3eb5
Compare
kripken
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing direct
__depsdeclarations for JS library symbols that previously relied on other callers pulling in their dependencies later in the dependency graph.With
__depssorted alphabetically (#28059), adding these missing direct edges ensures that automatically computing JS-to-JS dependencies (#27995) produces identical declaration ordering and zero diffs acrosstest/codesize/.See: #19098