Move convert_line_endings_in_file into link.py. NFC#26360
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
Move convert_line_endings_in_file into link.py. NFC#26360sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
This is the only file that uses it so we don't need to it in the shared utils.
kripken
reviewed
Feb 28, 2026
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Even if this is the one file that uses it, it is a general simple utility, which feels more at home in utils.py?
Collaborator
Author
|
Maybe. Its not a huge deal, but in general I try to keep |
Member
|
Fair enough. I don't feel strongly here, though I'd go the other way personally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the only file that uses it so we don't need to it in the shared utils.