Fix: When symbol is both imported and exported, don't drop import#26356
Open
hoodmane wants to merge 2 commits intoemscripten-core:mainfrom
Open
Fix: When symbol is both imported and exported, don't drop import#26356hoodmane wants to merge 2 commits intoemscripten-core:mainfrom
hoodmane wants to merge 2 commits intoemscripten-core:mainfrom
Conversation
hoodmane
force-pushed
the
fix-syscall-wrapping
branch
from
2ef32d4 to
6ab4594
Compare
This fixes wrapping syscalls with -sMAIN_MODULE and -sEXPORT_ALL. Resolves issue 26355.
hoodmane
force-pushed
the
fix-syscall-wrapping
branch
from
6ab4594 to
441ec3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes wrapping syscalls with -sMAIN_MODULE and -sEXPORT_ALL. Resolves #26355.