[CI] Cache the result of pip install and npm install#26338
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
[CI] Cache the result of pip install and npm install#26338sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
circleci_cache
branch
6 times, most recently
from
779b3ff to
b6b12f4
Compare
sbc100
force-pushed
the
circleci_cache
branch
from
b6b12f4 to
899f2e6
Compare
dschuff
reviewed
Feb 25, 2026
| command: << parameters.python >> -m pip install -r requirements-dev.txt | ||
| command: | | ||
| if [[ -e ~/.cache/pip ]]; then | ||
| echo "Skipping npm ci due to cache hit" |
Member
There was a problem hiding this comment.
If everything is already there, isn't npm ci just a no-op that runs fast?
Member
There was a problem hiding this comment.
Oh, actually this is pip, so the echo should be updated. but same question. i.e. could we just run the command anyway.
| steps: | ||
| - restore_cache: | ||
| keys: | ||
| - python-deps-v2-{{ arch }}-checksum "requirements-dev.txt" }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.