Fix named JS classes in libraries.#26056
Merged
brendandahl merged 2 commits intoemscripten-core:mainfrom Jan 14, 2026
Merged
Conversation
When a JS library contains a named class, the previous logic blindly prepended the mangled name, resulting in invalid syntax like 'class MyClass MyClass'. This change detects if a class name is already present (excluding 'extends') and replaces it correctly. Fixes emscripten-core#25840
brendandahl
requested review from
kripken and
sbc100
and removed request for
kripken
sbc100
approved these changes
Jan 9, 2026
sbc100
reviewed
Jan 9, 2026
sbc100
reviewed
Jan 9, 2026
| } | ||
|
|
||
| addToLibrary({ | ||
| $MyClass: MyClass, |
Collaborator
There was a problem hiding this comment.
Maybe just inline the class here? Or does the fix depend on it being out-of-line?
Collaborator
Author
There was a problem hiding this comment.
Inline is fine. However the ParentClass (just added in the test) has to be top level.
sbc100
approved these changes
Jan 9, 2026
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
When a JS library contains a named class, the previous logic blindly prepended the mangled name, resulting in invalid syntax like 'class MyClass MyClass'. This change detects if a class name is already present (excluding 'extends') and replaces it correctly. Fixes emscripten-core#25840
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a JS library contains a named class, the previous logic blindly prepended the mangled name, resulting in invalid syntax like 'class MyClass MyClass'. This change detects if a class name is already present (excluding 'extends') and replaces it correctly.
Fixes #25840