Skip to content

Update @glimmer/component's package.json to declare type=module - #21561

Merged
ef4 merged 1 commit into
mainfrom
nvp/glimmer-component-type-module
Aug 18, 2026
Merged

Update @glimmer/component's package.json to declare type=module#21561
ef4 merged 1 commit into
mainfrom
nvp/glimmer-component-type-module

Conversation

@NullVoxPopuli

@NullVoxPopuli NullVoxPopuli commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

I believe this to be safe, because

  • the failure case for type=module and ember-addons only comes up when a type=module library depends on a v1 addon
  • the requirement ember-source had for it to enable type=module (min ember-cli @ 7.0.1) is not relevant here because @glimmer/component does not have blueprints
  • @glimmer/component already required ember-auto-import @ v2

@github-actions

Copy link
Copy Markdown
Contributor

📊 Size report

Tarball size1.2 MB1.2 MB

dist/dev   No changes

File Before (Size / Brotli) After (Size / Brotli)
Total (Includes all files) 2 MB / 489.8 kB 2 MB / 489.8 kB

dist/prod   No changes

File Before (Size / Brotli) After (Size / Brotli)
./packages/shared-chunks/cache-{hash}.js 9.9 kB / 2.8 kB -92.9%↓697 B / -90.7%↓258 B
Total (Includes all files) 1.9 MB / 447.2 kB 1.9 MB / 447.2 kB

smoke-tests/v2-app-template/dist   No changes

File Before (Size / Brotli) After (Size / Brotli)
Total (Includes all files) 340.6 kB / 94.8 kB 340.6 kB / 94.8 kB

smoke-tests/v2-app-hello-world-template/dist   No changes

File Before (Size / Brotli) After (Size / Brotli)
Total (Includes all files) 132.4 kB / 37 kB 132.4 kB / 37 kB

🤖 This report was automatically generated by wyvox/pkg-size

@ef4
ef4 merged commit 182ae47 into main Aug 18, 2026
48 checks passed
@ef4
ef4 deleted the nvp/glimmer-component-type-module branch August 18, 2026 20:46
@github-actions github-actions Bot mentioned this pull request Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants