Refactor so that small apps don't pull in the old renderer as well as some classic things#21462
Open
NullVoxPopuli wants to merge 1 commit into
Open
Refactor so that small apps don't pull in the old renderer as well as some classic things#21462NullVoxPopuli wants to merge 1 commit into
NullVoxPopuli wants to merge 1 commit into
Conversation
Contributor
📊 Size reportTarball size — dist/dev 0.2%↑
dist/prod 0.2%↑
smoke-tests/v2-app-template/dist 0.04%↑
smoke-tests/v2-app-hello-world-template/dist -4.06%↓
🤖 This report was automatically generated by wyvox/pkg-size |
NullVoxPopuli
force-pushed
the
nvp/cleanup-3
branch
from
baa4932 to
d68b86d
Compare
NullVoxPopuli
changed the title
/* @__PURE__ */ decoration
NullVoxPopuli
force-pushed
the
nvp/cleanup-3
branch
from
d68b86d to
ad5de44
Compare
NullVoxPopuli
force-pushed
the
nvp/cleanup-3
branch
2 times, most recently
from
b4cf812 to
5d75be0
Compare
which modules have side-effects
NullVoxPopuli
force-pushed
the
nvp/cleanup-3
branch
from
5d75be0 to
16c8800
Compare
NullVoxPopuli
commented
Jun 24, 2026
| hash, | ||
| 'unique-id': uniqueId, | ||
| }; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
two branches with the same code
NullVoxPopuli
commented
Jun 24, 2026
| // class; deriving it from the definition (rather than importing it from | ||
| // the module that defines `Helper`) keeps this module from pulling in | ||
| // the classic object model when no classic helpers are in use. | ||
| let manager = getInternalHelperManager(definition); |
Contributor
Author
There was a problem hiding this comment.
I think this is safe because of the isClassicHelper check above
NullVoxPopuli
commented
Jun 24, 2026
| } | ||
|
|
||
| lookupBuiltInHelper(name: string): HelperDefinitionState | null { | ||
| assert( |
Contributor
Author
There was a problem hiding this comment.
not sure how I feel about this -- -prefixed things are private.
at the same time, we do eventually want to enable routing things for folks using renderComponent, but we only want that stuff to become available when importing router stuff
NullVoxPopuli
commented
Jun 24, 2026
Contributor
Author
There was a problem hiding this comment.
direct extraction from renderer.ts
NullVoxPopuli
commented
Jun 24, 2026
Contributor
Author
There was a problem hiding this comment.
used in the main/classic renderer here: https://github.com/emberjs/ember.js/pull/21462/changes#diff-cdf95f0c6c10226a54fbac271478aaa1defd908f0f998fec0f484e52d2544184R211
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still exploring ways to hint to bundlers that they can remove unused things