Rewrite commonly searched section - #1022
Open
kategengler wants to merge 2 commits into
Open
Conversation
kategengler
commented
Aug 7, 2026
kategengler
commented
Contributor
- Mostly to remove Ember.Template.helpers; this will be accurate for 7.1 and higher
- Separate out old commonly searched docs and specify modern alternatives
- Mostly to remove Ember.Template.helpers; this will be accurate for 7.1 and higher - Separate out old commonly searched docs and specify modern alternatives
❌ Deploy Preview for ember-api-docs failed.
|
jenweber
reviewed
Aug 18, 2026
| </li> | ||
| </ul> | ||
|
|
||
| <h2>Commonly reached for Classic documentation</h2> |
Contributor
There was a problem hiding this comment.
Suggested change
| <h2>Commonly reached for Classic documentation</h2> | |
| <h2>Classic documentation</h2> |
Optional, for conciseness and to keep visual hierarchy on the other heading (I originally suggested different wording but changed my mind while reviewing the visual diff)
jenweber
reviewed
Aug 18, 2026
Comment on lines
+115
to
+116
| <p>These are Classic Ember concepts that have modern replacements but are | ||
| still supported. Please avoid using them in new code.</p> |
Contributor
There was a problem hiding this comment.
Suggested change
| <p>These are Classic Ember concepts that have modern replacements but are | |
| still supported. Please avoid using them in new code.</p> | |
| <p>These are older Ember concepts that have modern replacements. Although they are | |
| still supported, it is best to avoid using them in new code.</p> |
Optional, minor wording changes. This kind of defines "classic" in case someone is unfamiliar.
Contributor
|
Suddenly GitHub won't let me post a real review or load the diff for me 🙃 but in the visual diff with Percy, I can see you are missing a dash after the first bullet point, for Components. Otherwise, looks good ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.