Repository navigation
feat: /build redirects to missing-elements.github.io/h5p/build/, with its fragment - #18
Merged
Merged
Conversation
…/, with its fragment The build page moved to the Missing Elements site, in that site's own look (missing-elements/missing-elements.github.io#8). build.html is now a redirect that keeps the address's fragment, so a link a chat wrote before, #source= and all, still builds; without JavaScript it refreshes to the new address. The page's code and tests go with it. /bundles/ stays until the next pack release, for copies of the h5p-author skill installed before the move. Closes #17
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
… check the no-script test's errors Without JavaScript the refresh goes to the new address with no fragment; the README said otherwise. The no-script test now asserts no page, console or policy errors, as the other does, and names what it leaves out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17. Also closes #16, which this supersedes: the build page takes the new site's own design, not the player's
page.css.Merge after missing-elements/missing-elements.github.io#8 is deployed, so the redirect never points at a page that isn't there yet.
What changed
build.htmlis now a redirect tohttps://missing-elements.github.io/h5p/build/. It keeps the address's fragment, so a link a chat wrote before,/build#source=…, still builds its source there. A query is dropped, such as the?utm_source=chatgpt.comChatGPT adds. Without JavaScript, a<noscript>refresh goes to the new address without the fragment, and the page links to it. The page isnoindexwith a canonical link. Its inline script is allowed by hash, which the existing CSP plugin writes.src/build-page.ts,src/build-source.ts,src/build.cssande2e/build.spec.ts. They live on in the new site, unchanged except the stylesheet./bundles/stays until the next library pack release, for copies of the h5p-author skill installed before the move. The plugin's comment and the README say when it goes and what goes with it: the plugin, its test and the@missing-elements/h5p-authordependency./buildis described as the redirect, with a short "The build page moved" section, and the bundles section has its end date.Tests
The new
e2e/build-redirect.spec.tsanswers the other site with a stand-in page and checks where the browser goes:/build#source=…arrives at…/h5p/build/#source=…, with and without a query;/buildarrives at…/h5p/build/;/buildstill arrives there.All 10 tests pass locally: the player page's, the bundles' and these. Mutation check: a redirect that drops
location.hashfails the first test, and it passes again once the line is restored.Summary by cubic
/buildnow redirects to the build page's new home at missing-elements.github.io/h5p/build, closing #17 and superseding #16. With JavaScript, the redirect keeps the address's fragment, so old/build#source=…links still build their source there; a query is dropped. Without JavaScript, a<noscript>refresh goes to the new address without the fragment./bundles/stays until the next library pack release, for skill copies installed before the move, then goes with its plugin, test and the@missing-elements/h5p-authordependency.Written for commit 0830b10. Summary will update on new commits.