Repository navigation
fix: build with author 0.5.1, and keep every script's letters in download names - #13
Merged
Merged
Conversation
…load names author 0.5.0 wrapped Question Set's intro title and results heading in <div>, which the set draws as text; 0.5.1 stores them plain (missing-elements/h5p-offline-player#164). A test now checks the cover shows its title as written, apostrophe and umlauts included. The download name kept ASCII letters only, so ß became a hyphen and a Cyrillic or Greek title became activity.h5p. It now keeps letters, marks and digits in any script. Closes #12
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12
Changes
package.json,pnpm-lock.yaml): Question Set's intro title and results heading are stored as plain text, not wrapped in<div>, and an apostrophe shows as typed there (missing-elements/h5p-offline-player#164). pnpm resolves one copy, with player 1.5.1 and pack 1.1.0 as before.src/build-source.ts,packageName): letters, marks and digits in any script, lower case, joined by hyphens, NFC, at most 60 characters. "Die größten Ereignisse" downloads asdie-größten-ereignisse.h5p, where it wasdie-gro-ten-ereignisse.h5p, and "Річки України" asрічки-україни.h5p, where it wasactivity.h5p.Testing
pnpm typecheck,pnpm build,pnpm e2e: 11 passed. Changed or new ine2e/build.spec.ts:<div>…</div>, as the live page shows now.After merging, the deploy puts 0.5.1 on the live page.
Summary by cubic
Upgrades
@missing-elements/h5p-authorto fix Question Set titles appearing with literal<div>tags. Download names now preserve letters from any writing system instead of stripping non-ASCII characters.Written for commit 0c7c31b. Summary will update on new commits.