Close TCP sockets on errors in HTTP/1 - #502
Merged
Merged
Conversation
In some cases, when handling a failure, Mint would only set the conn
state to :closed but would not close the underlying socket. These
sockets stay open until the calling process that owns them exits, and
may therefore accumulate until resources are exhausted.
Every relevant %{conn | state: :closed} inside Mint.HTTP1 is replaced
with internal_close that in addition to setting the state also closes
the socket.
Tests that asserted closed conn now also assert that the socket is
closed. New tests that demonstrate the problem are added. They would
fail without the fix and they pass with the fix in place.
Fixes elixir-mint#501.
Contributor
|
@xxdavid can you look at the Dialyzer failure in CI? |
The lines shifted a bit by the changes in the previous commit.
Contributor
Author
|
Ah, running Dialyzer did not cross my mind. Fortunately, it was just a stale line number in the ignore list. Thanks for the review! |
Member
|
Thank you! 馃挏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, when handling a failure, Mint would only set the conn state to
:closedbut would not close the underlying socket. These sockets stay open until the calling process that owns them exits, and may therefore accumulate until resources are exhausted.Every relevant
%{conn | state: :closed}insideMint.HTTP1is replaced withinternal_closethat in addition to setting the state also closes the socket.Tests that asserted closed conn now also assert that the socket is closed. New tests that demonstrate the problem are added. They would fail without the fix and they pass with the fix in place.
Fixes #501.