Skip to content

Conversation

@giddie
Copy link

@giddie giddie commented Jan 29, 2026

For anyone running the LSP in a dev container or otherwise simplified environment, we cannot rely on the presence of SHELL or the behaviour of a login shell to provide a clean PATH. I propose we instead filter out the RELEASE_ROOT from PATH, which seems to adequately address the issue of using the correct paths for ASDF/mise.

We cannot rely on the presence of SHELL or the behaviour of a login
shell because these things are often not available inside containers.
@github-actions
Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

A valid title has a type (feat, bug, chore, etc) followed by and optional scope in parentheses, a colon, a space, and then a subject which starts with a lowercase letter.

feat(engine): add new completions styles
bug: correctly index project symbols

Details:

No release type found in pull request title "Filter out RELEASE_ROOT from PATH instead of running a login shell". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@mhanberg
Copy link
Member

Would you be able to point me to documentation as to how the RELEASE_ROOT variable works and what it does?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants