Repository navigation
Close zipped and cycled streams properly on errors - #16135
Merged
josevalim merged 2 commits intoNov 14, 2026
Merged
Conversation
Signed-off-by: Mandar Joshi <mandarjoshi1045@gmail.com>
josevalim
reviewed
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16134.
When the consumer or one of the zipped streams raises,
Stream.zip/zip_withnow close the streams in their current state instead of the previous step's continuations, so resources are not started again just to be closed,after_funruns once, and it gets the current acc.Stream.cyclenow halts the suspended inner stream when the consumer raises.The new tests fail on main and pass with this change.