perf: Copy file mode with chmod instead of stat and write_stat - #15754
Open
tomciopp wants to merge 1 commit into
Open
perf: Copy file mode with chmod instead of stat and write_stat#15754tomciopp wants to merge 1 commit into
tomciopp wants to merge 1 commit into
Conversation
Contributor
Author
|
Filesystem benchmarks on macOS were too noisy to certify the wall clock effect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copy_file_mode/2read the destination'sfile_infopurely to rebuilda full record and write it back with only
:modechanged. Thedestination stat served no purpose:
:file.change_mode/2isimplemented as
write_file_infowith a mode-only record, so applyingthe source mode directly performs the same operation with one fewer
file-server round trip per file copied by
File.cp/3andFile.cp_r/3.Writing the full record back also had two unintended effects that
this removes: it attempted to set the destination's owner, which
POSIX permits to fail with EPERM for non-owner copies even when the
value is unchanged, and it rewrote the destination's timestamps with
the second-precision values read by stat, truncating the sub-second
mtime of the freshly written file.
Assisted by: Claude Fable.