Skip to content

Parallelize locale merging in mix gettext.merge #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Jun 10, 2026
+15 −3
Merged

Parallelize locale merging in mix gettext.merge #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Unreleased

* Parallelize per-locale merging in `mix gettext.merge`.

## v1.0.2

* Only skip manifest removal on Elixir v1.19.3+
Expand Down
14 changes: 11 additions & 3 deletions lib/mix/tasks/gettext.merge.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,17 @@ defmodule Mix.Tasks.Gettext.Merge do
end

defp merge_all_locale_dirs(pot_dir, opts, gettext_config) do
for locale <- File.ls!(pot_dir), File.dir?(Path.join(pot_dir, locale)) do
merge_dirs(locale_dir(pot_dir, locale), pot_dir, locale, opts, gettext_config)
end
pot_dir
|> File.ls!()
|> Enum.filter(&File.dir?(Path.join(pot_dir, &1)))
|> Task.async_stream(
fn locale ->
merge_dirs(locale_dir(pot_dir, locale), pot_dir, locale, opts, gettext_config)
end,
ordered: false,
timeout: :infinity
)
|> Stream.run()
end

def locale_dir(pot_dir, locale) do
Expand Down