Fix owner_unallow using wrong ref when switching owners#342
Merged
josevalim merged 1 commit intoelixir-ecto:masterfrom Mar 25, 2026
Merged
Conversation
When ownership_allow is called with unallow_existing: true to move a
process from one owner to another, owner_unallow was removing the
process from the caller's owner ref rather than the process's current
owner ref. This left the process in the old owner's allowed list.
When the old owner later exits, owner_down removes all processes in
its allowed list from checkouts — including the process that was
already re-allowed on a different owner. This causes an
OwnershipError on the next query because the process is no longer in
checkouts.
The fix looks up the process's current checkout entry to find its
actual ref and proxy, then cleans up the correct owner's allowed list.
Also fixes the ETS delete in owner_unallow which was passing
{pid, proxy} as the key instead of just pid — a no-op on a :set
table keyed by the first element.
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ownership_allow is called with unallow_existing: true to move a process from one owner to another, owner_unallow was removing the process from the caller's owner ref rather than the process's current owner ref. This left the process in the old owner's allowed list.
When the old owner later exits, owner_down removes all processes in its allowed list from checkouts — including the process that was already re-allowed on a different owner. This causes an OwnershipError on the next query because the process is no longer in checkouts.
The fix looks up the process's current checkout entry to find its actual ref and proxy, then cleans up the correct owner's allowed list.
Also fixes the ETS delete in owner_unallow which was passing {pid, proxy} as the key instead of just pid — a no-op on a :set table keyed by the first element.