Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .buildignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ webpack.config.js
.browserslistrc
.eslintignore
.eslintrc.js
.prettierrc
.npmrc
.stylelintrc

Expand Down
186 changes: 42 additions & 144 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,146 +1,44 @@
module.exports = {
extends: [
'plugin:react/recommended',
'plugin:no-jquery/deprecated',
'plugin:@wordpress/eslint-plugin/recommended-with-formatting',
],
plugins: [
'babel',
'react',
'no-jquery',
],
parser: '@babel/eslint-parser',
globals: {
wp: true,
window: true,
document: true,
_: false,
jQuery: false,
JSON: false,
elementorFrontend: true,
require: true,
elementor: true,
DialogsManager: true,
module: true,
React: true,
PropTypes: true,
__: true,
},
parserOptions: {
ecmaVersion: 2017,
sourceType: 'module',
ecmaFeatures: {
jsx: true,
},
},
rules: {
// custom canceled rules
'no-var': 'off',
'vars-on-top': 'off',
'wrap-iife': 'off',
'computed-property-spacing': [ 'error', 'always' ],
'comma-dangle': [ 'error', 'always-multiline' ],
'no-undef': 'off',
'no-unused-vars': [ 'warn', { ignoreRestSiblings: true } ],
'dot-notation': 'error',
'no-shadow': 'error',
'no-lonely-if': 'error',
'no-mixed-operators': 'error',
'no-nested-ternary': 'error',
'no-cond-assign': 'error',
'space-in-parens': [ 'error', 'always', { exceptions: [ 'empty' ] } ],
'no-multi-spaces': 'error',
'semi-spacing': 'error',
'quote-props': [ 'error', 'as-needed' ],
indent: [ 'off', 'tab', { SwitchCase: 1 } ],
'no-mixed-spaces-and-tabs': 'error',
'padded-blocks': [ 'error', 'never' ],
'one-var-declaration-per-line': 'error',
'no-extra-semi': 'error',
'key-spacing': 'error',
'array-bracket-spacing': [ 'error', 'always' ],
'no-else-return': 'error',
'no-console': 'warn',
//end of custom canceled rules
'arrow-parens': [ 'error', 'always' ],
'arrow-spacing': 'error',
'brace-style': [ 'error', '1tbs' ],
camelcase: [ 'error', { properties: 'never' } ],
'comma-spacing': 'error',
'comma-style': 'error',
'eol-last': 'error',
eqeqeq: 'error',
'func-call-spacing': 'error',
'jsx-quotes': 'error',
'keyword-spacing': 'error',
'lines-around-comment': 'off',
'no-bitwise': [ 'error', { allow: [ '^' ] } ],
'no-caller': 'error',
'no-debugger': 'warn',
'no-dupe-args': 'error',
'no-dupe-keys': 'error',
'no-duplicate-case': 'error',
'no-eval': 'error',
'no-multiple-empty-lines': [ 'error', { max: 1 } ],
'no-multi-str': 'off',
'no-negated-in-lhs': 'error',
'no-redeclare': 'error',
'no-restricted-syntax': [
'error',
{
selector: 'CallExpression[callee.name=/^__|_n|_x$/]:not([arguments.0.type=/^Literal|BinaryExpression$/])',
message: 'Translate function arguments must be string literals.',
},
{
selector: 'CallExpression[callee.name=/^_n|_x$/]:not([arguments.1.type=/^Literal|BinaryExpression$/])',
message: 'Translate function arguments must be string literals.',
},
{
selector: 'CallExpression[callee.name=_nx]:not([arguments.2.type=/^Literal|BinaryExpression$/])',
message: 'Translate function arguments must be string literals.',
},
],
'no-trailing-spaces': 'error',
'no-undef-init': 'error',
'no-unreachable': 'error',
'no-unsafe-negation': 'error',
'no-unused-expressions': 'error',
'no-useless-return': 'error',
'no-whitespace-before-property': 'error',
'object-curly-spacing': [ 'error', 'always' ],
'prefer-const': 'warn',
quotes: [ 'error', 'single', { allowTemplateLiterals: true, avoidEscape: true } ],
semi: 'error',
'space-before-blocks': [ 'error', 'always' ],
'space-before-function-paren': [ 'error', {
anonymous: 'never',
named: 'never',
asyncArrow: 'always',
} ],
'space-infix-ops': [ 'error', { int32Hint: false } ],
'space-unary-ops': [ 'error', {
overrides: {
'!': true,
yield: true,
},
} ],
'valid-typeof': 'error',
yoda: [ 'error', 'always', {
onlyEquality: true,
} ],
'react/react-in-jsx-scope': 'off',
'babel/semi': 1,
// 'react/display-name': 'off',
// 'react/jsx-curly-spacing': [ 'error', {
// when: 'always',
// children: true,
// } ],
// 'react/jsx-equals-spacing': 'error',
// 'react/jsx-indent': [ 'error', 'tab' ],
// 'react/jsx-indent-props': [ 'error', 'tab' ],
// 'react/jsx-key': 'error',
// 'react/jsx-tag-spacing': 'error',
// 'react/no-children-prop': 'off',
// 'react/prop-types': 'off',
},
extends: [
'plugin:react/recommended',
'plugin:no-jquery/deprecated',
'plugin:@wordpress/eslint-plugin/recommended-with-formatting',
'plugin:prettier/recommended',
],
plugins: ['babel', 'react', 'no-jquery'],
parser: '@babel/eslint-parser',
globals: {
wp: true,
window: true,
document: true,
_: false,
jQuery: false,
JSON: false,
elementorFrontend: true,
require: true,
elementor: true,
DialogsManager: true,
module: true,
React: true,
PropTypes: true,
__: true,
},
parserOptions: {
ecmaVersion: 2017,
sourceType: 'module',
ecmaFeatures: {
jsx: true,
},
},
rules: {
'no-undef': 'off',
'no-unused-vars': 'off',
yoda: [
'error',
'always',
{
onlyEquality: true,
},
],
},
};
10 changes: 10 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"useTabs": true,
"printWidth": 80,
"semi": true,
"singleQuote": true,
"endOfLine": "auto",
"arrowParens": "always",
"proseWrap": "always",
"bracketSpacing": true
}
3 changes: 1 addition & 2 deletions dev/js/editor/component.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ export default class extends $e.modules.ComponentBase {
}

defaultHooks() {
return this.importHooks( { ControlsHook } );
return this.importHooks({ ControlsHook });
}
}

3 changes: 1 addition & 2 deletions dev/js/editor/hello-editor.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import HelloComponent from './component';

$e.components.register( new HelloComponent() );

$e.components.register(new HelloComponent());
Loading
Loading