Skip to content

Show CPU count, cores and threads in a popover - #418

Open
vjr wants to merge 2 commits into
mainfrom
vishal/single-line-cpu-info
Open

vjr wants to merge 2 commits into
mainfrom
vishal/single-line-cpu-info

Conversation

@vjr

@vjr vjr commented Sep 14, 2026

Copy link
Copy Markdown
Member

Also presume the same CPU model for multi-socket so only show single line with model name instead of one line per physical CPU.

Also presume the same CPU model for multi-socket so only show single line with model name instead of one line per physical CPU.
@vjr vjr self-assigned this Sep 14, 2026
@vjr
vjr requested review from a team and ryonakano September 14, 2026 15:26
@vjr

vjr commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

Similar to elementary/monitor#549

@ryonakano

Copy link
Copy Markdown
Member

I'm not sure if we should move these info to a tooltip because it's not accessible on touchscreen devices.

@vjr

vjr commented Sep 15, 2026

Copy link
Copy Markdown
Member Author

I'm not sure if we should move these info to a tooltip because it's not accessible on touchscreen devices.

right! i can place the info in a popover attached to a round button with "information" icon, something like what monitor does next to the CPU name...

what about the rest of the diff, does it look okay/acceptable?

Place processor details in a popover on a info button.
@vjr vjr changed the title Show CPU count, cores and threads in a tooltip Show CPU count, cores and threads in a popover Sep 15, 2026
@vjr

vjr commented Sep 15, 2026

Copy link
Copy Markdown
Member Author

@ryonakano @danirabbit how does it look now?

@danirabbit

Copy link
Copy Markdown
Member

I don't understand why you're doing this actually. What's your goal here?

@vjr

vjr commented Sep 15, 2026

Copy link
Copy Markdown
Member Author

I don't understand why you're doing this actually. What's your goal here?

@danirabbit the current get_cpu_info () will return multiple lines of the same cpu model name on a multi socket computer, even though i know it's unlikely someone with a workstation like that might run a consumer OS like elementary?

also, the cpu model name is prepended with the core count which IMO could be meaningless or misleading especially since other desktop envs like KDE/GNOME show the logical threads count, so in elementary you could get:

16 x AMD Ryzen 9950X 16-Core while on KDE it shows 32 x AMD Ryzen 9950X 16-Core.

intention of this PR is two-fold:

  • to always only print a single line because the cpu models will be the same on a multi socket computer.
  • avoid showing vague/misleading prefix like 16 x ... and put the cpu topology in the popup to show something like:
CPUs: 2
Cores per CPU: 32
Threads per CPU: 64

Hope this is a reasonable change to make?

@vjr

vjr commented Sep 15, 2026

Copy link
Copy Markdown
Member Author

hmm, this PR could be useful for folks running in a VM where they can configure multi-socket, multi-core and logical threads per cpu/core?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants